alessandrobenedetti opened a new pull request, #2809: URL: https://github.com/apache/solr/pull/2809
https://issues.apache.org/jira/browse/SOLR-17525 # Description Scope of this issue is to integrate a new module able to use LLM (through managed services) to enhance aspect of Apache Solr. Specifically this first Pull Request relates to handle embedding models and automatic text vectorisation in Solr. # Solution The functionality has been introduced through LangChain4J (https://docs.langchain4j.dev). The are several aspects I would like feedback on: - I used inversion of control to integrate support for multiple embedding models with minimal impact on the code. It works and it's decently clean, but I would love your feedback on this - Embedding models are accessed through client APIS and http requests are made to embed text using external services. To do that I added security exceptions in both X and Y. It works but I have no idea if it's acceptable or the best way to do it # Tests - model storage tests added - query parsing tests added # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
