mkhludnev commented on code in PR #2742:
URL: https://github.com/apache/solr/pull/2742#discussion_r1807918145


##########
solr/core/src/java/org/apache/solr/search/facet/FacetParser.java:
##########
@@ -138,21 +139,30 @@ public Object parseFacetOrStat(String key, Object o) 
throws SyntaxError {
     return parseFacetOrStat(key, type, args);
   }
 
+  public interface ParseHandler {
+    Object doParse(FacetParser<?> parent, String key, Object args) throws 
SyntaxError;

Review Comment:
   btw, is there an other exemplar of such a naming convention like `doSometh` 
? why not just `parse`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to