malliaridis opened a new pull request, #2784: URL: https://github.com/apache/solr/pull/2784
https://issues.apache.org/jira/browse/SOLR-17467 # Description The current changes of this issue that were introduced in #2729 broke the start script on Windows. Executing `bin\solr.cmd start` failed with errors. See https://github.com/apache/solr/pull/2729#issuecomment-2424106562 for details. # Solution Changing these two lines seems to solve the issue. The one change makes sense, the other one doesn't. I guess it's magic. 😕 @epugh I added you as reviewer since you have made most of the work and should better understand the logic. # Tests _No tests were modified._ # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
