dsmiley commented on code in PR #2765:
URL: https://github.com/apache/solr/pull/2765#discussion_r1801734297
##########
solr/core/src/java/org/apache/solr/update/UpdateLog.java:
##########
@@ -2097,10 +2098,19 @@ public void doReplay(TransactionLog translog) {
UpdateRequestProcessorChain processorChain =
req.getCore().getUpdateProcessingChain(null);
Collection<UpdateRequestProcessor> procPool =
Collections.synchronizedList(new ArrayList<>());
+ final var params =
+ new MapSolrParams(
+ Map.of(
+ DISTRIB_UPDATE_PARAM,
+ FROMLEADER.toString(),
+ DistributedUpdateProcessor.LOG_REPLAY,
+ "true"));
ThreadLocal<UpdateRequestProcessor> procThreadLocal =
ThreadLocal.withInitial(
() -> {
- var proc = processorChain.createProcessor(req, rsp);
+ // SolrQueryRequest is not thread-safe, so use a copy when
creating URPs
+ final var solrQueryRequest = new
LocalSolrQueryRequest(uhandler.core, params);
Review Comment:
I'd call this var localRequest -- "local" being an important part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
