risdenk opened a new pull request, #2218: URL: https://github.com/apache/solr/pull/2218
https://issues.apache.org/jira/browse/SOLR-17130 # Description This unwraps the case of using edismax query parser and `q=*:*`. Prior to this change, `*:*` was being changed to `+*:*` which wraps the `MatchAllDocsQuery` with a boolean query. We can unwrap the boolean query since its not necessary if the `MatchAllDocsQuery` is the only clause. I found this by looking at https://issues.apache.org/jira/browse/SOLR-14765 and wondering why when using `edismax` the optimizations were skipped even though the query was `*:*`. The boolean wrapped `MatchAllDocsQuery` means that some of the optimization logic is skipped - https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java#L1623 # Tests Added tests to confirm that if `*` or `*:*` is the query then Solr returns just a `MatchAllDocsQuery` instead of a boolean wrapped `MatchAllDocsQuery`. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. - [x] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
