iamsanjay commented on PR #2724: URL: https://github.com/apache/solr/pull/2724#issuecomment-2381044293
As you must have seen now that we are doing the migration we are facing some challenges relating to HttpSolrClient, in some cases It also exposed HttpClient -- `SolrClientCloudManager`, `HttpSolrCall` are some of the examples. Of course we have not exposed HttpClient but once we start using concrete classes reference, It started to evolve on their own. For instance, adding requesAsync was the first example, and now in the new PR we are adding another method `requestWithUrl`. As our codebase evolve we will start seeing more and more Http2SolrClient reference, and during that we will keep on adding more and more to `Http2SolrClient` only. Yes; adding such method which throws `UnsupportedOpeartionException` is ugly. However, Lucene and our own codebase has good number of reference to UnsupportedOperationException. Even, Jdk uses it -- The collection framework, and lots of other places as well. But it is either choosing between this, or adding more methods to the concrete classes. If we decide to stick to `SolrClient`, we will definitely think of something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
