gerlowskija opened a new pull request, #2723: URL: https://github.com/apache/solr/pull/2723
# Description The 'solr.v2RealPath' system property was used to control how SolrJ built v2 API paths, seemingly as a workaround to allow certain tests to work which didn't at the time use a full Jetty stack. (Jetty.xml is involved in supporting our v2 API currently by rewriting the v2 API root "/api" to "/solr/____v2") This workaround though is unnecessary and needlessly complicates SolrJ's path-building logic. # Solution Remove all references to 'solr.v2RealPath' in our codebase, and ensure that all tests still pass. (This change targets 'main' only right now. It may also be safe to backport to branch_9x, but more investigation is needed there to see whether the user-configurable context-root causes any complications.) # Tests Existing tests continue to pass. No new tests, as this PR only removes functionality. # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
