dsmiley opened a new pull request, #2701: URL: https://github.com/apache/solr/pull/2701
Instead, use a caller-runs policy. https://issues.apache.org/jira/browse/SOLR-17414 This Executor is a bit special, and as such I don't think we should modify ExecutorUtil for the needs of one executor. I'd like to back out Christine's and Gus's change. Instead, MDCAwareThreadPoolExecutor can be subclasses wherever. Didn't do this yet. If we imagine this Executor is of general use, then its initialization should remain in CoreContainer. I put it in SolrIndexSearcher but could move it. IMO it is of general use; the multi-threaded faceting should use the same. So I'm inclined to move back. The queue size check should be configurable. I could see values like 1, or the same as the thread count. It'd be nice to block but without busy waiting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
