[
https://issues.apache.org/jira/browse/SOLR-12429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877032#comment-17877032
]
ASF subversion and git services commented on SOLR-12429:
--------------------------------------------------------
Commit c3eaa194c413febf250960ae233ea126d30b997b in solr's branch
refs/heads/branch_9x from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=c3eaa194c41 ]
SOLR-12429: Prevent symbolic links from being uploaded as part of a configset
(#2651)
* Add a check (and a test) of a symbolic link
(cherry picked from commit a276a0f42788044087a05561def9f7c7b9582081)
> ZK upconfig throws confusing error when it encounters a symlink
> ---------------------------------------------------------------
>
> Key: SOLR-12429
> URL: https://issues.apache.org/jira/browse/SOLR-12429
> Project: Solr
> Issue Type: Bug
> Components: SolrCLI
> Affects Versions: 7.3.1
> Reporter: Shawn Heisey
> Assignee: Eric Pugh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> If a configset being uploaded to ZK contains a symlink pointing at a
> directory, an error is thrown, but it doesn't explain the real problem. The
> upconfig should detect symlinks and throw an error indicating that they
> aren't supported. If we can detect any other type of file that upconfig
> can't use (sockets, device files, etc), the error message should be relevant.
> {noformat}
> Exception in thread "main" java.io.IOException: File
> '/var/solr/mbsssss/artist/conf/common' exists but is a directory
> at org.apache.commons.io.FileUtils.openInputStream(FileUtils.java:286)
> at
> org.apache.commons.io.FileUtils.readFileToByteArray(FileUtils.java:1815)
> at
> org.apache.solr.common.cloud.SolrZkClient.makePath(SolrZkClient.java:391)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils$1.visitFile(ZkMaintenanceUtils.java:305)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils$1.visitFile(ZkMaintenanceUtils.java:291)
> at java.nio.file.Files.walkFileTree(Files.java:2670)
> at java.nio.file.Files.walkFileTree(Files.java:2742)
> at
> org.apache.solr.common.cloud.ZkMaintenanceUtils.uploadToZK(ZkMaintenanceUtils.java:291)
> at
> org.apache.solr.common.cloud.SolrZkClient.uploadToZK(SolrZkClient.java:793)
> at
> org.apache.solr.common.cloud.ZkConfigManager.uploadConfigDir(ZkConfigManager.java:78)
> at org.apache.solr.cloud.ZkCLI.main(ZkCLI.java:236)
> {noformat}
> I have not tested whether a symlink pointing at a file works, but I think
> that an error should be thrown for ANY symlink.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
