[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Pugh resolved SOLR-3913.
-----------------------------
Fix Version/s: 9.8
Resolution: Fixed
> SimplePostTool optimize does a redundant commit
> -----------------------------------------------
>
> Key: SOLR-3913
> URL: https://issues.apache.org/jira/browse/SOLR-3913
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Reporter: David Smiley
> Assignee: Eric Pugh
> Priority: Minor
> Labels: pull-request-available
> Fix For: 9.8
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> At the end of SimplePostTool.execute() there is:
> {code}
> if (commit) commit();
> if (optimize) optimize();
> {code}
> Each of these calls involves a separate request to Solr. The thing is, an
> optimize internally commits, and so the logic should forgo committing is
> optimize is true.
> And as an aside, I think the 1kb pipe() buffer on line 893 is too small; it
> should be around 8kb (8192) bytes which is the same value as
> BufferedInputStream's default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
