[
https://issues.apache.org/jira/browse/SOLR-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876971#comment-17876971
]
ASF subversion and git services commented on SOLR-3913:
-------------------------------------------------------
Commit 94146c1c3084d18038a95c51b0e90e605b187922 in solr's branch
refs/heads/main from Eric Pugh
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=94146c1c308 ]
SOLR-3913: Optimize the commit/optimize cycle in the PostTool (#2667)
Arguably you shouldn't be able to pass in the skip-commit AND the optimize
options as the same time...?
> SimplePostTool optimize does a redundant commit
> -----------------------------------------------
>
> Key: SOLR-3913
> URL: https://issues.apache.org/jira/browse/SOLR-3913
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Reporter: David Smiley
> Assignee: Eric Pugh
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> At the end of SimplePostTool.execute() there is:
> {code}
> if (commit) commit();
> if (optimize) optimize();
> {code}
> Each of these calls involves a separate request to Solr. The thing is, an
> optimize internally commits, and so the logic should forgo committing is
> optimize is true.
> And as an aside, I think the 1kb pipe() buffer on line 893 is too small; it
> should be around 8kb (8192) bytes which is the same value as
> BufferedInputStream's default.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
