cpoerschke commented on code in PR #2607:
URL: https://github.com/apache/solr/pull/2607#discussion_r1699960636
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -2056,7 +2056,7 @@ public void reload(String name, UUID coreId) {
newCore = core.reload(coreConfig);
DocCollection docCollection = null;
- if (getZkController() != null) {
+ if (getZkController() != null && !newCore.isSynthetic()) {
docCollection =
getZkController().getClusterState().getCollection(cd.getCollectionName());
// turn off indexing now, before the new core is registered
if (docCollection.getBool(ZkStateReader.READ_ONLY, false)) {
Review Comment:
perhaps this would be a little controversial since it's modifying existing
behaviour for non-synthetic cores also, albeit error logic code path
```suggestion
docCollection =
getZkController().getClusterState().getCollectionOrNull(cd.getCollectionName());
// turn off indexing now, before the new core is registered
if (docCollection != null &&
docCollection.getBool(ZkStateReader.READ_ONLY, false)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
