[
https://issues.apache.org/jira/browse/SOLR-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869629#comment-17869629
]
ASF subversion and git services commented on SOLR-17298:
--------------------------------------------------------
Commit adc3f7abbd3074dd974dd5a04705565ca69e5332 in solr's branch
refs/heads/main from Gus Heck
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=adc3f7abbd3 ]
SOLR-17298 - ThreadCpuTimer safe for multi-threaded search (#2595)
* SOLR-17298 Simplify ThreadCpuTimer by never instantiating it, and instead
tracking any number of contexts per thread. This avoids thread safety issues
previously caused by keeping state in a field. Ensure explicit correspondence
between reported cpu time and the measurement of cpu used by limits when limits
are in play. Also add TestInjection for cpu delay and use it in
TestCpuAllowedLimit
> Multithreaded search breaks limits, and possibly other things
> -------------------------------------------------------------
>
> Key: SOLR-17298
> URL: https://issues.apache.org/jira/browse/SOLR-17298
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: main (10.0), 9.7, 9x
> Reporter: Gus Heck
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 9.7
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> https://issues.apache.org/jira/browse/SOLR-13350 was merged to main somewhat
> unexpectedly, and then back-ported to 9x without any response to feedback
> from multiple committers, including feedback that
> * By turning it on by default, it breaks the recently released CPU limits
> (as shown by changes to unit tests).
> * Incompatibility with timeAllowed, cpuTimeAllowed, segmentTerminateEarly,
> GraphQuery, RankQuery and JoinQuery was not clearly documented
> * The code presents a possibility for users to receive a non-numeric max
> score ("NaN").
> I have not verified it yet, but I would also be worried about the health of
> CPU time logging to be added in
> https://issues.apache.org/jira/browse/SOLR-16986 after this change.
> Given that:
> * Some of the above issues represent back compatibility breaks or potential
> back compatibility breaks for released features
> * The decision to break compatibility within the 9x release series deserves
> a formal vote (or a fix).
> * There has been no communication/response from the committer who merged
> these changes since May 6 (aside from the backport to 9x on May 13) it seems
> that this state may persist for some time.
> Therefore it appears necessary to file this issue to ensure anything but a
> 9.6.1 is blocked until the above issues are sorted out. This ticket can serve
> as a parent ticket to whatever various solutions are agreed upon.
> Multi-threaded search is an awesome feature that has taken a very long time
> to be realized and is obviously desirable, but we have now placed ourselves
> in an awkward position by not resolving these last few issues before back
> porting.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
