[
https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866143#comment-17866143
]
Chris M. Hostetter commented on SOLR-10654:
-------------------------------------------
{quote}Is this really specifically about Gauges (vs say Timers)? Any way, my
understanding is that we can call SolrMetricManager.removeRegistry on the
various registries. Perhaps tests generally or maybe just this test isn't
doing that. As we have test infrastructure that detects leaks of things, maybe
we need to detect a metric registry leak.
{quote}
I am not an expert on the dropwizard stuff, and it's been a while since i
looked at it, but yes: Gauges are particularly tricky to deal with from a
lifecycle standpoint, which is why Solr has it's own GaugeWrapper. But that
doesn't help us when other libraries register gauges.
SOLR-16918 (which i linked to previously) is an example of problematic gauge
lifecycle situations that (i believe) could leak between tests. Any gauges
created directly by jetty are also likeley to leak between tests – which is i
believe exactly what is happening here.
> Expose Metrics in Prometheus format DIRECTLY from Solr
> ------------------------------------------------------
>
> Key: SOLR-10654
> URL: https://issues.apache.org/jira/browse/SOLR-10654
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Keith Laban
> Priority: Major
> Attachments: prometheus_metrics.txt
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> Expose metrics via a `wt=prometheus` response type.
> Example scape_config in prometheus.yml:
> {code:java}
> scrape_configs:
> - job_name: 'solr'
> metrics_path: '/solr/admin/metrics'
> params:
> wt: ["prometheus"]
> static_configs:
> - targets: ['localhost:8983']
> {code}
> [Rationale|https://issues.apache.org/jira/browse/SOLR-11795?focusedCommentId=17261423&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17261423]
> for having this despite the "Prometheus Exporter". They have different
> strengths and weaknesses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
