janhoy commented on PR #2540: URL: https://github.com/apache/solr/pull/2540#issuecomment-2228245666
It’s the best I could do with my available time. I have NOT done a thorough review of all options in all tools, just fixed the ones causing test failures. The windows script lacks tests so who knows what works or not? Perhaps we are able to do follow up work on that front? If no one else are willing to do a more thorough manual review, I believe merging this as is, is better than not merging. And very important: some of my commits may include fixes that should be forward ported to main. We should make a placeholder JIRA to research what that might be. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
