[
https://issues.apache.org/jira/browse/SOLR-10654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864416#comment-17864416
]
Chris M. Hostetter commented on SOLR-10654:
-------------------------------------------
{{TestPrometheusResponseWriter.testPrometheusOutput}} has failed in 100% of the
jenkins builds that have run it since being added yesterday ... the problem
appears to be some jardcoded assumptions about metric ordering?
{noformat}
org.apache.solr.response.TestPrometheusResponseWriter > testPrometheusOutput
FAILED
org.junit.ComparisonFailure: expected:<... TYPE solr_metrics_j[]vm_buffers
gauge
sol...> but was:<... TYPE solr_metrics_j[etty_dispatches_total counter
solr_metrics_jetty_dispatches_total 0.0
# TYPE solr_metrics_jetty_requests_total counter
solr_metrics_jetty_requests_total{method="active"}
# TYPE solr_metrics_jetty_response_total counter
solr_metrics_jetty_response_total{status="2xx"}
# TYPE solr_metrics_j]vm_buffers gauge
sol...>
at
__randomizedtesting.SeedInfo.seed([76D2036CF55247FD:F7C26E458CF7A80B]:0)
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at
org.apache.solr.response.TestPrometheusResponseWriter.testPrometheusOutput(TestPrometheusResponseWriter.java:86)
{noformat}
Likewise {{MetricsHandlerTest.testPrometheusMetricsJvm}} has failed 50% of the
jenkins builds that jave run it since being added yesterday ... notably always
on Uwe's jenkins machine, suggesting some hardcoded assumptions about metrics
that may not be true in long running JVMs...
{noformat}
org.apache.solr.handler.admin.MetricsHandlerTest > testPrometheusMetricsJvm
FAILED
java.lang.AssertionError: expected:<0.0> but was:<3604480.0>
at
__randomizedtesting.SeedInfo.seed([5F3548D00F329FF4:577F9BC55C62D284]:0)
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:555)
at org.junit.Assert.assertEquals(Assert.java:685)
at
org.apache.solr.handler.admin.MetricsHandlerTest.testPrometheusMetricsJvm(MetricsHandlerTest.java:925)
{noformat}
> Expose Metrics in Prometheus format DIRECTLY from Solr
> ------------------------------------------------------
>
> Key: SOLR-10654
> URL: https://issues.apache.org/jira/browse/SOLR-10654
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Keith Laban
> Priority: Major
> Attachments: prometheus_metrics.txt
>
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> Expose metrics via a `wt=prometheus` response type.
> Example scape_config in prometheus.yml:
> {code:java}
> scrape_configs:
> - job_name: 'solr'
> metrics_path: '/solr/admin/metrics'
> params:
> wt: ["prometheus"]
> static_configs:
> - targets: ['localhost:8983']
> {code}
> [Rationale|https://issues.apache.org/jira/browse/SOLR-11795?focusedCommentId=17261423&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17261423]
> for having this despite the "Prometheus Exporter". They have different
> strengths and weaknesses.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
