[ 
https://issues.apache.org/jira/browse/SOLR-17349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864231#comment-17864231
 ] 

ASF subversion and git services commented on SOLR-17349:
--------------------------------------------------------

Commit 9a86b2102ef28f603a08fa7fdae153e7ae834960 in solr's branch 
refs/heads/main from Michael Gibney
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=9a86b2102ef ]

SOLR-17349: (adjusted) SolrDocumentFetcher should always skip lazy field 
loading overhead if documentCache==null (#2551)

* SOLR-17349: (adjusted) SolrDocumentFetcher should always skip lazy field 
loading overhead if documentCache==null

this also reverts the code change from 390c30ff56ad354a6ee55eaae54713dd8ec4cce3,
which is obviated by directly making `enableLazyFieldLoading` conditional
on presence of `documentCache`.

> SolrDocumentFetcher should always skip lazy field loading overhead if 
> documentCache==null
> -----------------------------------------------------------------------------------------
>
>                 Key: SOLR-17349
>                 URL: https://issues.apache.org/jira/browse/SOLR-17349
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: main (10.0), 8.11.3, 9.6.1
>            Reporter: Michael Gibney
>            Assignee: Michael Gibney
>            Priority: Minor
>             Fix For: 9.7
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> SolrDocumentFetcher currently still adds some overhead for lazy loading of 
> stored fields, even when there is no documentCache, in which case iiuc lazy 
> field loading should be irrelevant.
> I stumbled across this while looking into a [problem reported on the 
> solr-users 
> list|https://lists.apache.org/thread/myd6ckfd61xmdh2087or1to3t3m2flyn]. The 
> connection to the reported problem is still a bit mysterious (there are 
> as-yet-unexplained magic numbers involved), but in some cases at least, the 
> reported performance degradation was quite significant, and the reported 
> workaround circumstantially supports this change as a possible fix.
> I think this change is a positive one regardless; and if it ends up fixing 
> the reported issue, so much the better!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to