uschindler commented on code in PR #2501:
URL: https://github.com/apache/solr/pull/2501#discussion_r1641924594
##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -389,7 +389,7 @@ private void doWebMode() {
numPagesPosted = postWebPages(args, 0, out);
info(numPagesPosted + " web pages indexed.");
- } catch (MalformedURLException e) {
+ } catch (URISyntaxException e) {
Review Comment:
I would make this consistent to other code and prefer a clear exception.
##########
solr/core/src/java/org/apache/solr/cli/PostTool.java:
##########
@@ -389,7 +389,7 @@ private void doWebMode() {
numPagesPosted = postWebPages(args, 0, out);
info(numPagesPosted + " web pages indexed.");
- } catch (MalformedURLException e) {
+ } catch (URISyntaxException e) {
Review Comment:
URISyntaxException is only thrown by `new URI()`, the create function does
not. Not sure how we should handle this.
See documentation of `URI#create(String)`: "This convenience factory method
works as if by invoking the
[URI(String)](https://docs.oracle.com/javase%2F8%2Fdocs%2Fapi%2F%2F/java/net/URI.html#URI-java.lang.String-)
constructor; any
[URISyntaxException](https://docs.oracle.com/javase%2F8%2Fdocs%2Fapi%2F%2F/java/net/URISyntaxException.html)
thrown by the constructor is caught and wrapped in a new
[IllegalArgumentException](https://docs.oracle.com/javase%2F8%2Fdocs%2Fapi%2F%2F/java/lang/IllegalArgumentException.html)
object, which is then thrown."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
