patsonluk commented on PR #2438: URL: https://github.com/apache/solr/pull/2438#issuecomment-2159229315
> Can a SyntheticSolrCore be prevented from registering itself with CoreContainer? I would imagine so since this functionality is inserted at the HttpSolrCall level thus the SolrCore could come from wherever. It might be less hacky to prevent weird/unusual SolrCores from presenting themselves in the CoreContainer to other functionality (who knows) that is expecting normal cores. I don't have a strong opinion on this; just sharing. I think that's a very good question! AFAIK, we probably really only need `SyntheticSolrCore` be present when `CoordinatorHttpSolrCall` is doing its special logic, which means in theory, it does not have to live within the`CoreContainer`/`SolrCores`. And it will be much cleaner w/o that! I will investigate a bit and see if there are any dependencies that prevent us from doing that 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
