dsmiley commented on code in PR #2491:
URL: https://github.com/apache/solr/pull/2491#discussion_r1626425833
##########
solr/modules/hdfs/src/java/org/apache/solr/hdfs/update/HdfsUpdateLog.java:
##########
@@ -81,31 +77,15 @@ public void init(PluginInfo info) {
log.info("Initializing HdfsUpdateLog: tlogDfsReplication={}",
tlogDfsReplication);
}
- private Configuration getConf(Path path) {
- Configuration conf = new Configuration();
- if (confDir != null) {
- HdfsUtil.addHdfsResources(conf, confDir);
- }
-
- String fsScheme = path.toUri().getScheme();
- if (fsScheme != null) {
- conf.setBoolean("fs." + fsScheme + ".impl.disable.cache", true);
- }
- return conf;
- }
-
@Override
- public void init(UpdateHandler uhandler, SolrCore core) {
-
- // ulogDir from CoreDescriptor overrides
- String ulogDir = core.getCoreDescriptor().getUlogDir();
-
- this.uhandler = uhandler;
-
+ protected boolean initCheckRepoen(SolrCore core) {
synchronized (fsLock) {
// just like dataDir, we do not allow
// moving the tlog dir on reload
if (fs == null) {
+ // ulogDir from CoreDescriptor overrides
+ String ulogDir = core.getCoreDescriptor().getUlogDir();
Review Comment:
(note I didn't write this code; I just moved these 2 lines)
I think the logic around dataDir / ulogDir resolution is pretty confusing;
I'm not comfortable improving this TBH without a bigger investment it than my
goal right now. Note init() can be called additional times for core reloads so
the dataDir will hold whatever it had from before. It appears that's pertinent.
@magibney touched similar code recently; maybe would offer input
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
