dsmiley commented on code in PR #76: URL: https://github.com/apache/solr/pull/76#discussion_r1619398738
########## solr/core/src/java/org/apache/solr/handler/component/TaskManagementHandler.java: ########## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.component; + +import org.apache.solr.common.SolrException; +import org.apache.solr.common.params.CommonParams; +import org.apache.solr.common.params.ModifiableSolrParams; +import org.apache.solr.common.params.ShardParams; +import org.apache.solr.core.CoreContainer; +import org.apache.solr.core.SolrCore; +import org.apache.solr.handler.RequestHandlerBase; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.solr.security.PermissionNameProvider; +import org.apache.solr.util.plugin.SolrCoreAware; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import java.util.Map; + +import static org.apache.solr.common.params.CommonParams.DISTRIB; +import static org.apache.solr.common.params.CommonParams.PATH; + +/** + * Abstract class which serves as the root of all task managing handlers + */ +public abstract class TaskManagementHandler extends RequestHandlerBase implements SolrCoreAware, PermissionNameProvider { + private ShardHandlerFactory shardHandlerFactory; + + @Override + public void inform(SolrCore core) { + this.shardHandlerFactory = core.getCoreContainer().getShardHandlerFactory(); + } + + /** + * Process the actual request. + * extraParams is required for allowing sub handlers to pass in custom parameters to be put in the + * outgoing shard request + */ + protected void processRequest(SolrQueryRequest req, ResponseBuilder rb, Map<String, String> extraParams) throws IOException { + ShardHandler shardHandler = shardHandlerFactory.getShardHandler(); + List<SearchComponent> components = rb.components; Review Comment: @atris I'm commenting on this years later, I realize, but I question the complexity in this design in using SearchComponents. SearchComponents are designed expressly for SearchHandler; to allow many interesting features to exist together in a search pipeline of sorts for one request. Pretty excellent. Here, I see that the same design was used but only for one function -- a simple requirement. It's a heavyweight solution for a simple task. If your answer is, for distributed-processing -- that's not necessary. For example see org.apache.solr.handler.admin.AdminHandlersProxy#maybeProxyToNodes (granted I don't love it) or places in SolrCloud that use ShardHandler directly (better). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
