AndreyBozhko commented on code in PR #2471:
URL: https://github.com/apache/solr/pull/2471#discussion_r1617551538
##########
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java:
##########
@@ -694,16 +694,32 @@ public <T> boolean addToCoreAware(T obj) {
}
}
- void initCore(SolrCore core) {
Review Comment:
So there was `initCore(SolrCore)` and `inform(SolrCore)` - the former felt
more like a typical setter to me, so I renamed the existing method, and named
the two new methods in a similar fashion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
