[
https://issues.apache.org/jira/browse/SOLR-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-15438:
--------------------------------
Resolution: Duplicate
Status: Resolved (was: Patch Available)
Closing as the ideas here are mostly addressed in a fix for SOLR-17118 and
somewhat also by SOLR-15590
> Refactor: Simplify SolrDispatchFilter close/destroy
> ---------------------------------------------------
>
> Key: SOLR-15438
> URL: https://issues.apache.org/jira/browse/SOLR-15438
> Project: Solr
> Issue Type: Improvement
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> SolrDispatchFilter's close process is more convoluted than it needs to be.
> There is conditionality via a boolean closeOnDestory that JettySolrRunner
> uses, yet it seems it doesn't really need this logic. JSR could instead call
> Jetty FilterHolder stop() method which tracks lifecycle to know if it hasn't
> been called, and it can skip needless null checks. Also SDF's reference to
> CoreContainer needn't be null'ed out, which makes some logic simpler above
> that needn't guard against null. The HttpClient needn't be null'ed either.
> We don't need a reference to SolrMetricManager; it can be gotten from
> CoreContainer easily.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
