AndreyBozhko commented on code in PR #2472:
URL: https://github.com/apache/solr/pull/2472#discussion_r1610122730


##########
solr/solr-ref-guide/modules/configuration-guide/pages/caches-warming.adoc:
##########
@@ -86,7 +86,6 @@ The async cache provides most significant improvement with 
many concurrent queri
 However, the async cache will not prevent data races for time-limited queries, 
since those are expected to provide partial results.
 
 All caches can be disabled using the parameter `enabled` with a value of 
`false`.
-Caches can also be disabled on a query-by-query basis with the `cache` 
parameter, as described in the section 
xref:query-guide:common-query-parameters.adoc#cache-local-parameter[cache Local 
Parameter].

Review Comment:
   @epugh The doc does say that caches can be toggled in solrconfig.xml:
   ```
   All caches can be disabled using the parameter `enabled` with a value of 
`false`.
   ```
   
   But the **`cache` local parameter** only works with the filter cache, - so I 
removed all mentions of that parameter from the doc, and only kept one mention 
in the `Filter Cache` section (which redirects to Common Query Parameters).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to