dsmiley commented on code in PR #2429: URL: https://github.com/apache/solr/pull/2429#discussion_r1600677935
########## solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java: ########## @@ -164,7 +164,8 @@ public NamedList<Object> request(SolrRequest<?> request, String coreName) if (handler != null) { try { SolrQueryRequest req = - _parser.buildRequestFrom(null, request.getParams(), getContentStreams(request)); + _parser.buildRequestFrom( Review Comment: That underscore is from 2008 by Ryan McKinley -- long time ago :-) BTW I really appreciate that you are caring to these minor matters, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org