dsmiley commented on code in PR #1019: URL: https://github.com/apache/solr/pull/1019#discussion_r1600674211
########## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ########## Review Comment: @noblepaul , the change in ZkController.publishNodeAsDown was done on the conditional side that is not "distributedClusterStateUpdater". Thus if distributed state updates is enabled, would it work incorrectly if PRS is also enabled? I know you recently enabled some randomized use of PRS. Given that distributed updates is also randomized, maybe there is some test coverage for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
