andywebb1975 commented on PR #2433: URL: https://github.com/apache/solr/pull/2433#issuecomment-2104861532
@jdyer1 does this look good to go to you? Note I've another version which refactors part of the code, I think making it clearer - but let's keep that separate. I've a question in there which applies to the current code too - see https://github.com/apache/solr/pull/2454. Any thoughts on that? Andy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
