dsmiley commented on code in PR #2453:
URL: https://github.com/apache/solr/pull/2453#discussion_r1596067352
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -629,12 +624,6 @@ private static class MakeRequestReturnValue {
}
}
- private Request makeRequestAndSend(
Review Comment:
used to be longer but after recent changes, it's pointless; inlining is clear
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -438,13 +435,14 @@ public CompletableFuture<NamedList<Object>> requestAsync(
future.completeExceptionally(e);
return future;
}
- final ResponseParser parser =
- solrRequest.getResponseParser() == null ? this.parser :
solrRequest.getResponseParser();
mrrv.request
.onRequestQueued(asyncTracker.queuedListener)
.onComplete(asyncTracker.completeListener)
.send(
new InputStreamResponseListener() {
+ // MDC snapshot from requestAsync's thread
+ MDCCopyHelper mdcCopyHelper = new MDCCopyHelper();
Review Comment:
just reducing the scope of this var
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -438,13 +435,14 @@ public CompletableFuture<NamedList<Object>> requestAsync(
future.completeExceptionally(e);
return future;
}
- final ResponseParser parser =
- solrRequest.getResponseParser() == null ? this.parser :
solrRequest.getResponseParser();
Review Comment:
not used; the parser *is* used but is considered elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
