epugh commented on PR #2417: URL: https://github.com/apache/solr/pull/2417#issuecomment-2092493146
> > @laminelam I just merged in the latest, notice the compressor stuff for `ZkCpTool`? I really wish that all happened INSIDE of the zkclient tool.. not when you create it. oh well... Can you just quickly review my commits and then I think we are good to go! > > LGTM, although not familiar with "_withStateFileCompression_". Are you switching intentionally from "_solrhome_" to "_solr-home_"? ZKCli uses "_solrhome_" instead. withStateFileCompression is a feature for compressing state.json that only existed in ZKCli, so when I deprecated ZKCLI (gone now in `main`) I had to bring it across. and yeah, solrhome becomes solr-home in SolrCLI... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
