rseitz commented on PR #2404: URL: https://github.com/apache/solr/pull/2404#issuecomment-2082885569
Thanks @epugh and @dsmiley for the feedback and support for this fix. I'll open a separate ticket for the security.json refactor and tag Eric. There is a minor followup I would like to add here: `EmbeddedSolrServer.request()` has _two_ places where `_parser.buildRequestFrom()` is called. One codepath is when the request handler can be found on the CoreContainer, and the other codepath is when the request handler has to be retrieved from the SolrCore itself. This PR so far only updated the second codepath because that's the path that's active in the subquery execution scenario. To be consistent though, I'm thinking the first codepath should be updated as well. It's a one-line change just to add the Principal to a _parser.buildRequestFrom(). I'm planning to submit to this same branch shortly. Since existing unit tests don't seem to care about this, I'd be interested in any advice on if & how we should add coverage for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
