dsmiley commented on code in PR #2417:
URL: https://github.com/apache/solr/pull/2417#discussion_r1583046307
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudLegacySolrClient.java:
##########
@@ -379,7 +387,7 @@ public CloudLegacySolrClient build() {
"Both zkHost(s) & solrUrl(s) have been specified. Only specify
one.");
} else if (!zkHosts.isEmpty()) {
this.stateProvider =
- ClusterStateProvider.newZkClusterStateProvider(zkHosts,
zkChroot, canUseZkACLs);
+ ClusterStateProvider.newZkClusterStateProvider(zkHosts,
zkChroot, canUseZkACLs, solrClassLoader);
Review Comment:
We're adding a SolrClassLoader just for this? Instead, ZkStateReader can
instantiate this newZkClusterStateProvider itself (with the right class loader).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
