HoustonPutman commented on code in PR #660:
URL: https://github.com/apache/solr-operator/pull/660#discussion_r1572878677
##########
controllers/util/solr_security_util.go:
##########
@@ -238,7 +238,7 @@ func addHostHeaderToProbe(httpGet *corev1.HTTPGetAction,
host string) {
func cmdToPutSecurityJsonInZk() string {
scriptsDir := "/opt/solr/server/scripts/cloud-scripts"
- cmd := " ZK_SECURITY_JSON=$(%s/zkcli.sh -zkhost ${ZK_HOST} -cmd get
/security.json); "
+ cmd := " ZK_SECURITY_JSON=$(%s/zkcli.sh -zkhost ${ZK_HOST} -cmd get
/security.json || echo 'failed-to-get-security.json'); "
Review Comment:
So generally we try to avoid pod updates for patch versions, however for
security fixes or bad bugs, then it becomes necessary. There was a security fix
that required a pod template update, so this bug fix seemed like a good idea to
include as well. Sorry for the confusion though. I do remember writing docs
somewhere that security fixes might necessitate pod upgrades on a patch fix,
but I can't seem to find it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
