laminelam commented on code in PR #2378:
URL: https://github.com/apache/solr/pull/2378#discussion_r1570859249
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudHttp2SolrClient.java:
##########
@@ -422,7 +422,10 @@ public CloudHttp2SolrClient build() {
}
} else if (!solrUrls.isEmpty()) {
try {
- stateProvider = new Http2ClusterStateProvider(solrUrls,
httpClient);
+ if (this.internalClientBuilder != null) {
+ this.httpClient = internalClientBuilder.build();
Review Comment:
Actually I have 2 PRs that I am pretty sure would help a lot on this.
One that fixes this bug.
And anther one that I talked about
[here](https://github.com/apache/solr/pull/1994#discussion_r1535512663) where I
refactored ZK related SolrCli tools to separate _SolrZkClient_ and
_CloudHttp2SolrClient_ instantiation/usage.
Will see if I can speed up the internal review and push them upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
