rseitz commented on code in PR #2404:
URL: https://github.com/apache/solr/pull/2404#discussion_r1568088624
##########
solr/core/src/java/org/apache/solr/client/solrj/embedded/EmbeddedSolrServer.java:
##########
@@ -215,8 +215,9 @@ public NamedList<Object> request(SolrRequest<?> request,
String coreName)
if (handler == null) {
throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "unknown
handler: " + path);
}
-
- req = _parser.buildRequestFrom(core, params, getContentStreams(request));
+ req =
+ _parser.buildRequestFrom(
Review Comment:
We could remove the buildRequestFrom() that doesn't take a Principal;
outside of tests, it's used in only two places. Where it's used in
`EmbeddedSolrServer.request(SolrRequest<?> request, String coreName)`, we could
get the Principal from the SolrRequest. Where it's used in
`DirectSolrConnection.request(SolrRequestHandler handler, SolrParams params,
String body)` I think we'd need to pass a null Principal as I'm not seeing
where to get one from in that context.
About the larger question -- are there lots of other cases where enabling
basic auth causes errors -- I don't think I know enough to give a good answer.
I do think that the subquery use case is the most obvious/glaring place for
such an error to arise because it involves creating and executing a brand new
query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
