cpoerschke commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1531943470
##########
solr/core/src/java/org/apache/solr/spelling/WordBreakSolrSpellChecker.java:
##########
@@ -62,15 +62,15 @@ public class WordBreakSolrSpellChecker extends
SolrSpellChecker {
public static final String PARAM_MIN_BREAK_WORD_LENGTH = "minBreakLength";
/** See {@link BreakSuggestionTieBreaker} for options. */
- public static final String PARAM_BREAK_SUGGESTION_TIE_BREAKER =
"breakSugestionTieBreaker";
+ public static final String PARAM_BREAK_SUGGESTION_TIE_BREAKER =
"breakSuggestionTieBreaker";
Review Comment:
subjective: Wondering if for the 9.x line of releases we might want to
maintain backwards compatibility for user convenience e.g.
```suggestion
@Deprecated since 9.6 and will be removed from 10.0
private static final String PARAM_BREAK_SUGESTION_TIE_BREAKER =
"breakSugestionTieBreaker";
public static final String PARAM_BREAK_SUGGESTION_TIE_BREAKER =
"breakSuggestionTieBreaker";
```
here and reading both in the code. That way users upgrading (say) from 9.5
to 9.6 need not upgrade their configuration just as yet but they would receive
a friendly WARNing logging or so to let them know about the rename.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
