alessandrobenedetti opened a new pull request, #2348: URL: https://github.com/apache/solr/pull/2348
https://issues.apache.org/jira/browse/SOLR-17018 # Description Learning To Rank was ignoring any queryLimit parameter (such as timeAllowed) during the reranking phase. This means that a particularly expensive feature to extract may cause extremely slow responses and failures out of control. # Solution The idea is to check the query limits after the rescore of each search result (Learning To Rank rescore topK results). If the query limit is exhausted before the completion of the rescoring, the reranking is aborted and reverted (all or nothing approach). The response is marked as a partialResult and the original score and ranking are returned. # Tests A test has been added with a simple Learning To Rank model that uses just one single slow feature (implemented with a sleep function query). This feature simulates a slow feature extraction. # Checklist Please review the following and check all that apply: - [ X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X ] I have created a Jira issue and added the issue ID to my pull request title. - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ X] I have developed this patch against the `main` branch. - [X ] I have run `./gradlew check`. - [ X] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
