janhoy commented on issue #403: URL: https://github.com/apache/solr-operator/issues/403#issuecomment-1981656332
I maintained a custom solr.xml because I needed to activate OTEL tracer tag. But now that is auto activated when the right env.var is present, so one less reason to customize. I ran into issues with having to template `sharedLib` and `<backup>` tags. Luckily I can now let operator generate solr.xml once more. But for those who have custom needs, it would be nice if the operator could add in those dynamic parts. For `sharedLib` and `modules` the operator can add the sysProps and all is good if user has the substitution var defined. For `<backup>` repositories, we could document that the user can add a marker XML comment: ``` <!--SOLR-OPERATOR-BACKUP--> ``` Now the operator can take the XML string from the custom configMap and search-replace the marker with the generated backup tags, and stuff it into a new configMap. Should there be need for other "managed" tags in the future, new markes can be documented. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
