dsmiley commented on code in PR #2304:
URL: https://github.com/apache/solr/pull/2304#discussion_r1511522416
##########
solr/core/src/java/org/apache/solr/handler/admin/api/GetNodeCommandStatus.java:
##########
@@ -51,25 +51,24 @@ public GetNodeCommandStatus(
public GetNodeCommandStatusResponse getCommandStatus(String requestId) {
ensureRequiredParameterProvided(CoreAdminParams.REQUESTID, requestId);
var requestStatusResponse = new GetNodeCommandStatusResponse();
- if
(coreAdminAsyncTracker.getRequestStatusMap(RUNNING).containsKey(requestId)) {
- requestStatusResponse.status = RUNNING;
- } else if
(coreAdminAsyncTracker.getRequestStatusMap(COMPLETED).containsKey(requestId)) {
- requestStatusResponse.status = COMPLETED;
- requestStatusResponse.response =
-
coreAdminAsyncTracker.getRequestStatusMap(COMPLETED).get(requestId).getRspObject();
- requestStatusResponse.response =
- coreAdminAsyncTracker
- .getRequestStatusMap(COMPLETED)
- .get(requestId)
- .getOperationRspObject();
- } else if
(coreAdminAsyncTracker.getRequestStatusMap(FAILED).containsKey(requestId)) {
- requestStatusResponse.status = FAILED;
- requestStatusResponse.response =
-
coreAdminAsyncTracker.getRequestStatusMap(FAILED).get(requestId).getRspObject();
- } else {
+
+ TaskObject taskObject =
coreAdminAsyncTracker.getAsyncRequestForStatus(requestId);
+ String status = taskObject != null ? taskObject.getStatus() : null;
+
+ if (status == null) {
requestStatusResponse.status = "notfound";
requestStatusResponse.msg = "No task found in running, completed or
failed tasks";
+ } else {
+ requestStatusResponse.status = status;
+
+ if (taskObject.getStatus().equals(COMPLETED)) {
+ requestStatusResponse.response = taskObject.getRspObject();
+ requestStatusResponse.response = taskObject.getOperationRspObject();
Review Comment:
Ah; didn't know it was existing code. Do in whichever order you want; it
doesn't really matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
