noblepaul commented on code in PR #1964:
URL: https://github.com/apache/solr/pull/1964#discussion_r1510478108
##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -1679,19 +1698,21 @@ public static String getCollectionPath(String coll) {
* @see ZkStateReader#unregisterCore(String)
*/
public void registerCore(String collection) {
- AtomicBoolean reconstructState = new AtomicBoolean(false);
+ AtomicReference<StateWatcher> newWatcherRef = new AtomicReference<>();
collectionWatches.compute(
collection,
(k, v) -> {
if (v == null) {
- reconstructState.set(true);
- v = new StatefulCollectionWatch();
+ StateWatcher stateWatcher = new StateWatcher(collection);
Review Comment:
can we replace this with
```
v = new StatefulCollectionWatch(new StateWatcher(collection));
newWatcherRef.set(v.associatedWatcher);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
