madrob commented on code in PR #2312: URL: https://github.com/apache/solr/pull/2312#discussion_r1504868184
########## solr/core/src/java/org/apache/solr/security/PKIAuthenticationPlugin.java: ########## @@ -153,7 +153,9 @@ public boolean doAuthenticate( PKIHeaderData headerData = null; String headerV2 = request.getHeader(HEADER_V2); String headerV1 = request.getHeader(HEADER); - if (headerV2 != null) { + if (headerV1 == null && headerV2 == null) { Review Comment: This makes the null check at L165 redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org