gerlowskija commented on code in PR #2231:
URL: https://github.com/apache/solr/pull/2231#discussion_r1471105803
##########
solr/core/src/test/org/apache/solr/handler/admin/CoreAdminHandlerTest.java:
##########
@@ -377,7 +378,8 @@ public void testUnloadForever() throws Exception {
runner.start();
try (SolrClient client =
- new HttpSolrClient.Builder(runner.getBaseUrl() + "/corex")
+ new HttpSolrClient.Builder(runner.getBaseUrl().toString())
Review Comment:
Yeah, I wondered that as well, lots of URL->String logic.
I had similar thoughts about `Replica`...tons of places where we create a
HSC using the baseUrl and coreName pulled out of a `Replica` object.
But both of those are probably beyond the scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
