dsmiley commented on code in PR #2226:
URL: https://github.com/apache/solr/pull/2226#discussion_r1468049718
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseHttpClusterStateProvider.java:
##########
@@ -155,7 +156,12 @@ private ClusterState fetchClusterState(
for (Map.Entry<String, Object> e : collectionsMap.entrySet()) {
@SuppressWarnings("rawtypes")
Map m = (Map) e.getValue();
- cs = cs.copyWith(e.getKey(), fillPrs(znodeVersion, e, m));
+ Long creationTimeMillisFromClusterStatus = (Long)
m.get("creationTimeMillis");
+ Instant creationTime =
Review Comment:
Can we use null rather than lie that it was 1970?
##########
solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java:
##########
@@ -393,6 +411,8 @@ public String toString() {
+ getZNode()
+ "/"
+ znodeVersion
+ + "//"
Review Comment:
Do you think this stat is important enough to put itself in the toString? I
lean to "no".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
