[ 
https://issues.apache.org/jira/browse/SOLR-17119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17810429#comment-17810429
 ] 

ASF subversion and git services commented on SOLR-17119:
--------------------------------------------------------

Commit f8160ebdfa6942e54d3e43bd95aab0f11c53a96b in solr's branch 
refs/heads/main from Yohann Callea
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=f8160ebdfa6 ]

SOLR-17119: Fix exception swallowing in /cluster/plugins (#2202)

When registering or updating a ConfigurablePlugin through the `/cluster/plugin` 
API,
  config validation exceptions are now propagated to the callers.

> Exception swallowing in ContainerPluginsApi causes some config validation 
> errors to be ignored
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-17119
>                 URL: https://issues.apache.org/jira/browse/SOLR-17119
>             Project: Solr
>          Issue Type: Bug
>          Components: Plugin system, v2 API
>    Affects Versions: 9.4
>            Reporter: Yohann Callea
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> When registering a _ConfigurablePlugin_ through the _/cluster/plugin_ API 
> using the _V2Request_ client, exceptions raised within theĀ _*void 
> configure(T*_ *_cfg)_* method are swallowed in ContainerPluginsApi.
> This behavior can be troublesome as the exceptions raised in the 
> configure(...) method are usually validation errors on the configuration to 
> be applied, which are therefore ignored and allow for invalid plugin 
> configuration to become effective.
> I proposed a change in 
> [apache/solr#2202|https://github.com/apache/solr/pull/2202] to remediate this 
> issue along with a test to illustrate the scenario and validate the fix.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to