dsmiley commented on code in PR #2202:
URL: https://github.com/apache/solr/pull/2202#discussion_r1463627890


##########
solr/CHANGES.txt:
##########
@@ -140,6 +140,9 @@ Improvements
 
 * SOLR-17096: solr.xml now supports declaring clusterSingleton plugins (Paul 
McArthur, David Smiley)
 
+* SOLR-17119: When registering a ConfigurablePlugin through the 
`/cluster/plugin` API using the

Review Comment:
   Please move to 9.6



##########
solr/CHANGES.txt:
##########
@@ -140,6 +140,9 @@ Improvements
 
 * SOLR-17096: solr.xml now supports declaring clusterSingleton plugins (Paul 
McArthur, David Smiley)
 
+* SOLR-17119: When registering a ConfigurablePlugin through the 
`/cluster/plugin` API using the
+  V2Request client, config validation exceptions are now propagated to the 
callers (Yohann Callea)

Review Comment:
   Suggest rewording "the V2Request client" to "SolrJ with V2Request".   
(people know SolrJ is a client and this word sets better context to users who 
have no clue what V2Request even is).
   
   Curious; is"V2Request" actually pertinent to the bug?  Would someone using 
plain HTTP see the problem?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to