gerlowskija commented on code in PR #2173:
URL: https://github.com/apache/solr/pull/2173#discussion_r1442103850


##########
solr/solrj/src/java/org/apache/solr/common/util/URLUtil.java:
##########


Review Comment:
   Yeah, I think that'd probably make sense (moving `normalizeSolrUrl` that 
is).  We've got this nice class just for those sort of utilities, so might as 
well use it 🤷 
   
   The only hiccup I'd imagine that might cause is that it looks like `nSU` 
uses a static 'CLIO' object that SolrCLI has access to.  But I'm sure there's 
ways to straighten that out...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to