pvcnt commented on code in PR #2039:
URL: https://github.com/apache/solr/pull/2039#discussion_r1410856493
##########
solr/core/src/java/org/apache/solr/handler/admin/api/RestoreCollectionAPI.java:
##########
@@ -70,15 +69,17 @@
@Path("/backups/{backupName}/restore")
public class RestoreCollectionAPI extends BackupAPIBase {
- private static final Set<String> CREATE_PARAM_ALLOWLIST =
- Set.of(
- COLL_CONF,
- REPLICATION_FACTOR,
- NRT_REPLICAS,
- TLOG_REPLICAS,
- PULL_REPLICAS,
- CREATE_NODE_SET_PARAM,
- CREATE_NODE_SET_SHUFFLE_PARAM);
+ private static final Set<String> CREATE_PARAM_ALLOWLIST =
makeCreateParamAllowList();
+
+ private static Set<String> makeCreateParamAllowList() {
Review Comment:
Good suggestion, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
