murblanc commented on code in PR #2039: URL: https://github.com/apache/solr/pull/2039#discussion_r1410428468
########## solr/core/src/java/org/apache/solr/cloud/api/collections/CollectionHandlingUtils.java: ########## @@ -135,6 +140,20 @@ public class CollectionHandlingUtils { } } + /** Returns names of properties that are used to specify a number of replicas of a given type. */ Review Comment: I see. But I'd still value more a cleaner object oriented design vs packaging/deployment concerns. SolrJ exposes a lot of internals to clients so within that framework I think it makes sense to group code related to the same concepts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org