pvcnt commented on code in PR #2039:
URL: https://github.com/apache/solr/pull/2039#discussion_r1409396424
##########
solr/solrj/src/java/org/apache/solr/common/cloud/ReplicaCount.java:
##########
@@ -100,6 +166,10 @@ public int total() {
return countByType.values().stream().reduce(Integer::sum).orElse(0);
}
+ public int count(EnumSet<Replica.Type> replicaTypes) {
Review Comment:
The rationale was the same as for moving `validate` out of here and not
having `leaderEligibleTypes` on `Replica.Type`: I would like solrj to have as
little business logic as possible (even if it makes the code a bit less elegant
in solr-core).
Ideally, solrj and solr-core would have different objects to represent
replica types, but that is a much larger refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
