marcingorski commented on code in PR #87: URL: https://github.com/apache/solr-sandbox/pull/87#discussion_r1400397092
########## crossdc-producer/src/main/java/org/apache/solr/update/processor/MirroringUpdateProcessor.java: ########## @@ -107,18 +110,24 @@ UpdateRequest createMirrorRequest() { doc.removeField(CommonParams.VERSION_FIELD); // strip internal doc version final long estimatedDocSizeInBytes = ObjectSizeEstimator.estimate(doc); log.info("estimated doc size is {} bytes, max size is {}", estimatedDocSizeInBytes, maxMirroringDocSizeBytes); + producerMirroringMetrics.getDocumentsSize().update(estimatedDocSizeInBytes); Review Comment: Renamed to `documentSize`. ########## crossdc-producer/src/main/java/org/apache/solr/update/processor/KafkaRequestMirroringHandler.java: ########## @@ -51,6 +53,7 @@ public void mirror(UpdateRequest request) throws MirroringException { final MirroredSolrRequest mirroredRequest = new MirroredSolrRequest(MirroredSolrRequest.Type.UPDATE, 1, request, TimeUnit.MILLISECONDS.toNanos(System.currentTimeMillis())); try { sink.submit(mirroredRequest); + producerMirroringMetrics.getMessages().inc(); Review Comment: Renamed to `submitted`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org