gerlowskija commented on PR #2052: URL: https://github.com/apache/solr/pull/2052#issuecomment-1812583106
Alright - I'll remove it. If the signature was less complex I'd be worried about deleting a method that users might be relying on in their tests, but looking at it, it'd take a pretty advanced user to invoke it. It does raise an interesting question about whether backcompat even applies to solr-test-framework. As someone who's used it in 3rd-party projects (e.g. [spark-solr](https://github.com/lucidworks/spark-solr/blob/master/pom.xml#L532)) it is a pain when breaking changes happen. But at the same time, it probably doesn't require quite as rigid a backcompat-policy as a true client library like SolrJ. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
